sm-exts/accelerator
1
0
Fork 0
mirror of https://github.com/asherkin/accelerator.git synced 2025-12-06 18:08:30 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix symbol uploads (#43)
Some checks failed
Release / main-ci (push) Has been cancelled
Details
Release / release (push) Has been cancelled
Details

Browse Source 
* Fix parameter order

* Do not preserve address offset

* Do not pass explicit symbol ID
This commit is contained in:
Adrian-Stefan Mares 2025-11-30 18:06:45 +01:00 committed by GitHub
parent 3ed1266798
commit a661a6abb7
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
extension/extension.cpp
View File

@ -565,17 +565,17 @@ class UploadThread: public IThread
}; };
std::ostringstream outputStream; std::ostringstream outputStream;
google_breakpad::DumpOptions options(ALL_SYMBOL_DATA, true, true, true); google_breakpad::DumpOptions options(ALL_SYMBOL_DATA, true, true, false);
{ {
StderrInhibitor stdrrInhibitor; StderrInhibitor stdrrInhibitor;
if (!WriteSymbolFile(debugFile, debugFile, debugFile, "Linux", debug_dirs, options, outputStream)) { if (!WriteSymbolFile(debugFile, debugFile, "Linux", "", debug_dirs, options, outputStream)) {
outputStream.str(""); outputStream.str("");
outputStream.clear(); outputStream.clear();
// Try again without debug dirs. // Try again without debug dirs.
if (!WriteSymbolFile(debugFile, debugFile, debugFile, "Linux", {}, options, outputStream)) { if (!WriteSymbolFile(debugFile, debugFile, "Linux", "", {}, options, outputStream)) {
if (log) fprintf(log, "Failed to process symbol file\n"); if (log) fprintf(log, "Failed to process symbol file\n");
if (log) fflush(log); if (log) fflush(log);
return false; return false;