mirror of
https://github.com/asherkin/accelerator.git
synced 2025-12-06 18:08:30 +00:00
1d60f3746a
* overhaul the repository add protobuf change repo url try to restore github python syntax highlighter move breakpad into third_party, update packagescript * AMBuildifying remove unnecessary files Move the git patching into ambuild move lss to a patch Add windows compilation support remove breakpad.bat move postlink libs * Overhaul CI (#4) * Dockerbuild (#5) * make cwd_cmd spew stdout and stderr * add proper docker build support * Overhaul ci (#6) * Setup CI * fix checkout * fix yaml syntax * no fail fast * setup CI cache * Fix pip install * remove pip git * update actions, ditch node 16 * small syntax cleanups * more CI changes * github doc lied --------- Co-authored-by: Kenzzer <kenzzer@users.noreply.github.com> * final push for perfect dockerbuilds in every scenario that i have been able to find * rename cicd->dockerbuild --------- Co-authored-by: Kenzzer <kenzzer@users.noreply.github.com> * Add readme, remode duplicate -fPIC update names of dockerbuild folder in sh files * cleanup dockerfile (#7) * Update 0002-Write-FUNC-records-instead-of-PUBLIC-for-ELF-symbols.patch * Statically link libz, libgcc & libstdc++ * fix submodule path * Review change + comment patch --------- Co-authored-by: Kenzzer <kenzzer@users.noreply.github.com> Co-authored-by: Benoist <14257866+Kenzzer@users.noreply.github.com>
49 lines
2.0 KiB
Diff
49 lines
2.0 KiB
Diff
From 1f35257db226d6d0189cff0832a97cccc639c91a Mon Sep 17 00:00:00 2001
|
|
From: Asher Baker <asherkin@limetech.io>
|
|
Date: Sun, 13 Jan 2019 12:34:45 +0000
|
|
Subject: [PATCH 1/5] Ignore invalid modules rather than bailing on the entire
|
|
module list
|
|
|
|
---
|
|
src/processor/minidump.cc | 13 ++++++++++---
|
|
1 file changed, 10 insertions(+), 3 deletions(-)
|
|
|
|
diff --git a/src/processor/minidump.cc b/src/processor/minidump.cc
|
|
index 83e5a868..a7d564f2 100644
|
|
--- a/src/processor/minidump.cc
|
|
+++ b/src/processor/minidump.cc
|
|
@@ -3195,7 +3195,7 @@ bool MinidumpModuleList::Read(uint32_t expected_size) {
|
|
BPLOG(ERROR) << "MinidumpModuleList could not read required module "
|
|
"auxiliary data for module " <<
|
|
module_index << "/" << module_count;
|
|
- return false;
|
|
+ continue;
|
|
}
|
|
|
|
// It is safe to use module->code_file() after successfully calling
|
|
@@ -3207,7 +3207,14 @@ bool MinidumpModuleList::Read(uint32_t expected_size) {
|
|
BPLOG(ERROR) << "MinidumpModuleList found bad base address for module "
|
|
<< module_index << "/" << module_count << ", "
|
|
<< module.code_file();
|
|
- return false;
|
|
+ continue;
|
|
+ }
|
|
+
|
|
+ if (module_size == static_cast<uint32_t>(-1)) {
|
|
+ BPLOG(ERROR) << "MinidumpModuleList found bad size for module "
|
|
+ << module_index << "/" << module_count << ", "
|
|
+ << module.code_file();
|
|
+ continue;
|
|
}
|
|
|
|
// Some minidumps have additional modules in the list that are duplicates.
|
|
@@ -3234,7 +3241,7 @@ bool MinidumpModuleList::Read(uint32_t expected_size) {
|
|
<< module_index << "/" << module_count << ", "
|
|
<< module.code_file() << ", " << HexString(base_address)
|
|
<< "+" << HexString(module_size);
|
|
- return false;
|
|
+ continue;
|
|
}
|
|
|
|
// If failed due to apparent range overlap the cause may be the client
|