source/hl2sdk
1
0
Fork 0
mirror of https://github.com/alliedmodders/hl2sdk.git synced 2025-12-06 18:18:23 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
Half-Life 2 SDK Mirrors
127 Commits 27 Branches 0 Tags 720 MiB
C++ 94.6%
C 4.8%
GLSL 0.3%
Perl 0.2%
0edbd27fb8
Go to file
sigsegv 0edbd27fb8 Backport swap() -> V_swap() rename to avoid C++11 ADL ambiguity errors 
The swap() function provided in the MathLib header was renamed to V_swap in recent Source SDK versions (e.g. 2013) to avoid causing ambiguity problems with std::swap(). But older SDK versions (such as TF2) lack this change, as they predate it.

The ambiguity between MathLib's swap() and std::swap() causes considerable problems when using newer features of C++ (such as std::unique_ptr) which internally call swap() in an unqualified manner to implement move semantics:

/usr/include/c++/5.2.0/bits/unique_ptr.h:342:6: error: call of overloaded ‘swap(MyType*&, MyType*&)’ is ambiguous
/usr/include/c++/5.2.0/bits/move.h:176:5: note: candidate: void std::swap(_Tp&, _Tp&) [with _Tp = MyType*]
hl2sdk-tf2/public/mathlib/mathlib.h:611:18: note: candidate: void swap(T&, T&) [with T = MyType*]

This patch backports the swap() -> V_swap() rename from the 2013 SDK version to the TF2 SDK version, so that the TF2 SDK can be used in conjunction with C++11 features such as std::unique_ptr without difficulty.

More information on why swap() isn't called in a namespace-qualified manner by standard library functions:
http://en.cppreference.com/w/cpp/language/adl#Notes
2016-01-24 16:44:52 -08:00
choreoobjects Modified SDK for GCC 4.2 2008-09-15 02:50:57 -05:00
common Fixed conflict between min/max macros and std::min/max when using GCC >= 4.2. 2011-04-28 01:30:09 -05:00
devtools/bin Added most recent version of unmodified HL2 SDK for Orange Box engine 2008-09-15 01:07:45 -05:00
game Backport swap() -> V_swap() rename to avoid C++11 ADL ambiguity errors 2016-01-24 16:44:52 -08:00
lib Recompile Linux and Mac tier1. 2015-07-13 20:54:49 -04:00
linux_sdk Fixed SHLIBSUFFIX typos in Linux/OSX Makefile. 2013-04-27 10:28:01 -05:00
mathlib Backport swap() -> V_swap() rename to avoid C++11 ADL ambiguity errors 2016-01-24 16:44:52 -08:00
public Backport swap() -> V_swap() rename to avoid C++11 ADL ambiguity errors 2016-01-24 16:44:52 -08:00
tier1 Port KeyValues class from Source SDK 2013. 2015-07-12 15:44:04 -04:00
utils Backport swap() -> V_swap() rename to avoid C++11 ADL ambiguity errors 2016-01-24 16:44:52 -08:00
vgui2/vgui_controls Fixed conflict between min/max macros and std::min/max when using GCC >= 4.2. 2011-04-28 01:30:09 -05:00
.hgignore Added .hgignore file. 2011-04-10 01:41:48 -05:00
Everything_SDK-2005.sln Modified SDK for GCC 4.2 2008-09-15 02:50:57 -05:00
Game_Episodic-2005.sln Added most recent version of unmodified HL2 SDK for Orange Box engine 2008-09-15 01:07:45 -05:00
Game_HL2-2005.sln Added most recent version of unmodified HL2 SDK for Orange Box engine 2008-09-15 01:07:45 -05:00
Game_HL2MP-2005.sln Added most recent version of unmodified HL2 SDK for Orange Box engine 2008-09-15 01:07:45 -05:00
Game_Scratch-2005.sln Added most recent version of unmodified HL2 SDK for Orange Box engine 2008-09-15 01:07:45 -05:00
notes.txt Modified SDK for GCC 4.2 2008-09-15 02:50:57 -05:00