From b1fd9941bab982e5f0d92b31bd3b220ada90c78f Mon Sep 17 00:00:00 2001 From: Pavol Marko Date: Fri, 12 Oct 2007 19:19:17 +0000 Subject: [PATCH] Fixed comment (forgot to fix it in the last commit) --HG-- extra : convert_revision : svn%3Ac2935e3e-5518-0410-8daf-afa5dab7d4e3/trunk%40504 --- sourcehook/generate/sourcehook.h | 6 +----- sourcehook/generate/sourcehook.hxx | 6 +----- sourcehook/sourcehook.h | 6 +----- 3 files changed, 3 insertions(+), 15 deletions(-) diff --git a/sourcehook/generate/sourcehook.h b/sourcehook/generate/sourcehook.h index d6d3216..3804ce9 100644 --- a/sourcehook/generate/sourcehook.h +++ b/sourcehook/generate/sourcehook.h @@ -989,11 +989,7 @@ SourceHook::CallClass *SH_GET_CALLCLASS(T *p) bool IsEqual(ISHDelegate *pOtherDeleg) { return m_Deleg == static_cast(pOtherDeleg)->m_Deleg; } \ }; -// :FIXME: -// sizeof on references returns the size of the datatype, NOT the pointer size or something -// -> one should probably flag references in __SourceHook_ParamSizes_* ! -// or simply assume that their size is sizeof(void*)=SH_PTRSIZE... could be doable through a simple template - +// GetPassInfo -> easier access. __SH_GPI generates a SourceHook::PassInfo instance. #define __SH_GPI(tt) { sizeof(tt), ::SourceHook::GetPassInfo< tt >::type, ::SourceHook::GetPassInfo< tt >::flags } diff --git a/sourcehook/generate/sourcehook.hxx b/sourcehook/generate/sourcehook.hxx index 164f73a..a914407 100755 --- a/sourcehook/generate/sourcehook.hxx +++ b/sourcehook/generate/sourcehook.hxx @@ -989,11 +989,7 @@ SourceHook::CallClass *SH_GET_CALLCLASS(T *p) bool IsEqual(ISHDelegate *pOtherDeleg) { return m_Deleg == static_cast(pOtherDeleg)->m_Deleg; } \ }; -// :FIXME: -// sizeof on references returns the size of the datatype, NOT the pointer size or something -// -> one should probably flag references in __SourceHook_ParamSizes_* ! -// or simply assume that their size is sizeof(void*)=SH_PTRSIZE... could be doable through a simple template - +// GetPassInfo -> easier access. __SH_GPI generates a SourceHook::PassInfo instance. #define __SH_GPI(tt) { sizeof(tt), ::SourceHook::GetPassInfo< tt >::type, ::SourceHook::GetPassInfo< tt >::flags } @[$1,0,$a: diff --git a/sourcehook/sourcehook.h b/sourcehook/sourcehook.h index d6d3216..3804ce9 100644 --- a/sourcehook/sourcehook.h +++ b/sourcehook/sourcehook.h @@ -989,11 +989,7 @@ SourceHook::CallClass *SH_GET_CALLCLASS(T *p) bool IsEqual(ISHDelegate *pOtherDeleg) { return m_Deleg == static_cast(pOtherDeleg)->m_Deleg; } \ }; -// :FIXME: -// sizeof on references returns the size of the datatype, NOT the pointer size or something -// -> one should probably flag references in __SourceHook_ParamSizes_* ! -// or simply assume that their size is sizeof(void*)=SH_PTRSIZE... could be doable through a simple template - +// GetPassInfo -> easier access. __SH_GPI generates a SourceHook::PassInfo instance. #define __SH_GPI(tt) { sizeof(tt), ::SourceHook::GetPassInfo< tt >::type, ::SourceHook::GetPassInfo< tt >::flags }