From 02e85b3d9838f0bd1e6a58a98756b9a1a0eabd0b Mon Sep 17 00:00:00 2001 From: Nick Hastings Date: Sun, 7 Jul 2024 11:11:14 -0400 Subject: [PATCH] upload_symbols: fix finding dump_syms on Windows when relying on PATH --- tools/buildbot/upload_symbols.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tools/buildbot/upload_symbols.py b/tools/buildbot/upload_symbols.py index 9756fdb5c..9d106d968 100644 --- a/tools/buildbot/upload_symbols.py +++ b/tools/buildbot/upload_symbols.py @@ -1,4 +1,5 @@ # vim: ts=8 sts=2 sw=2 tw=99 et ft=python: +import shutil import sys import subprocess import os @@ -14,6 +15,9 @@ if len(sys.argv) < 3: SYMBOL_SERVER = os.environ['BREAKPAD_SYMBOL_SERVER'] symbol_file = sys.argv[1] cmd_argv = sys.argv[2:] + +# Find the dump_syms executable. (On Windows, subprocess.Popen doesn't use PATH unless shell=True.) +cmd_argv[0] = shutil.which(cmd_argv[0]) sys.stdout.write(' '.join(cmd_argv)) sys.stdout.write('\n')