When an admin initiates a ban from a BaseBans GUI menu, track players by
their AuthId (SteamID) instead of userid, so that the admin is able to
target players who disconnect after that menu was constructed.
If the target player is still connected, use their userid to ban the
same as before this commit.
If the target has disconnected, write a ban using their stored AuthId
value, as with "sm_addban".
This commit also revertss the `(admin==0)` check from PrepareBan that
was mistakenly added by bf7212889b,
because it would prevent banning from server/RCON (client index 0).
Fix#1768
The `sm_admin`-triggered Menu flow for banning players is caching client
indices inside the basebans.sp `PlayerInfo` struct, and can then
incorrectly use them in the menu callback without checking for the
related client's UserId validity. This leads to bug #1768 occurring when
the ban target player disconnects from the server before the banning
admin could complete the banmenu UI flow.
Since the related menu callbacks can't rely on the cached client index,
I have removed the basebans.sp `PlayerInfo.banTarget` member entirely,
in favor of the `PlayerInfo.banTarget`, and instead call
`GetClientOfUserId(...)` to get & validate the target client index where
necessary. The `PrepareBan(...)` function has been refactored to take a
ban target UserId (instead of the target client index) accordingly.
I removed the word Aptauja since in this context it isn't the right word to use https://tezaurs.lv/aptauja:1 and changed it to this word https://tezaurs.lv/balso%C5%A1ana:1
Example: I was asked by a stranger on the street to participate in the "Aptaujā"
Example 2: I went to the biggest shopping mall in Latvia to participate in the "Balsošānā", the year's best actor.
Added missing translation + Can't Nominate Current Map translation was changed because The sentence in Latvian doesn't sound good + the chosen word wasn't the best option in this sentence.
* Update SDKCall return information
This adds the information that if the return value is a string then SDKCall will return the number of bytes written.
* Update description
* Add info if the string is null
The current ``KvSavePosition`` definition does not reflect the behaviour seen in [core/smn_keyvalues.cpp#L973-L981](404e96ad45/core/smn_keyvalues.cpp (L973-L981)). This can cause problems if some procedure on sp expects ``KvSavePosition`` to always add one node to the stack, no matter if there is no higher node.
Co-authored-by: peace-maker <peace-maker@wcfan.de>
* Fix translations workflow
* Temporarily trigger workflow for PRs
* Trigger without a PR
* Just work please
* Update github-app-token dependency
* Update workflow step name
* Disable on PRs again
* Remove obsolete slapslay.phrases.txt
That plugin isn't in the stock arsenal since forever.
* Remove "Dead Player Rename" phrase
Unused since #313
* Remove nominations phrases from rockthevote
Those phrases were moved to their own nominations.phrases.txt
* Remove "Next Map" phrase from nextmap.phrases.txt
It was moved to basetriggers.phrases.txt
* Remove unused phrases from common.phrases.txt
Only "Slapped Player" was moved to funvotes.phrases.txt
* Delete empty phrase files
* Fix workflow python version selection
3.10 would select Python 3.1 and fail
* Deduplicate "Please select a map" phrase
Only keep it in the plugin.basecommands.txt file and remove it from the basevotes.phrases.txt.
Both plugins using the phrase load the basecommands phrases.
* Allow manual triggering of translations action
* Actually use the nextmap phrases
They were never referenced in the plugin. The "ago" phrase doesn't work the way it is and needs more rethinking.
* translations: bring languages into tree
* Update translation phrases changed since 2021
* Update packaging script to include all translations
* Update languages.cfg
* Add Latin American Spanish translations
This is a copy of spanish for now.
* Ignore "en" when looking for translation folders
English is the default and doesn't use a subfolder.
* Only add each translation folder once
Korean "ko" is in there twice.
* Compare language coverage to english
All phrases are compared to the english baseline files and any differences
are reported. The differences are pushed to a Github Project as well for
an easier overview.
Thank you to @nosoop for sharing the Python SMC parser!
* Add link to README
---------
Co-authored-by: Peace-Maker <peace-maker@wcfan.de>
The Ubuntu 18.04 runner image is deprecated and will be unsupported on 2023/04/01. It appears Ubuntu 20.04 has a package for clang-8, so just do the switch.
Addie said:
test the signatures:
\x55\x89\xE5\x57\x56\x53\x81\xEC\x8C\x01\x00\x00\x8B\x55\x08
or
digby's \x55\x89\xE5\x57\x56\x53\x81\xEC\x8C\x01\x00\x00\x8B\x55\x2A\x65\xA1
\x55\x89\xE5\x57\x56\x53\x81\xEC\x8C\x01\x00\x00\x8B\x55\x08 fixed the issue for linux server.
